Add enabled check to register() method to prevent service registration when disabled #7

Copilot · 2025-10-11T06:11:50Z

Problem

The otel.enabled configuration check was only implemented in the boot() method but was missing from the register() method. This meant that even when OpenTelemetry was disabled via configuration, the service provider would still register all services into the Laravel container, including:

Measure and Metric support classes
TracerInterface and MeterInterface bindings
MeterProvider initialization
ShutdownHandler registration

This resulted in unnecessary resource consumption and potential side effects when OpenTelemetry was intentionally disabled.

Solution

Added the same otel.enabled configuration check to the register() method that was already present in the boot() method. When OpenTelemetry is disabled, the method now returns early after merging the configuration, preventing any service registration.

public function register(): void
{
    $this->mergeConfigFrom(
        __DIR__.'/../config/otel.php', 'otel',
    );

    // Check if OpenTelemetry is enabled
    if (! config('otel.enabled', true)) {
        return;
    }

    // ... rest of service registration
}

Benefits

Resource efficiency: Prevents unnecessary service initialization when OpenTelemetry is disabled
Consistency: Both register() and boot() methods now follow the same pattern
Clean container: Services are only registered when they will actually be used

Testing

Added a comprehensive test test_provider_does_not_register_services_when_disabled() that verifies:

Services are not bound to the container when otel.enabled is false
The test creates a fresh application instance to avoid interference from test setup
All existing tests (218) continue to pass

Fixes the issue reported where the enabled check was only in boot() and needed to be added to register() as well.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/CarbonPHP/carbon-doctrine-types/zipball/18ba5ddfec8976260ead6e866180bd5d2f71aa1d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/CarbonPHP/carbon/zipball/8e3643dcd149ae0fe1d2ff4f2c8e4bbfad7c165f
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/GrahamCampbell/Result-Type/zipball/3ba905c11371512af9d9bdd27d99b782216b6945
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/Nevay/spi/zipball/e7078767866d0a9e0f91d3f9d42a832df5e39002
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/Nyholm/psr7-server/zipball/4335801d851f554ca43fa6e7d2602141538854dc
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/Seldaek/monolog/zipball/10d85740180ecba7896c87e06a166e0c95a0e3b6
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/brick/math/zipball/113a8ee2656b882d4c3164fa31aa6e12cbb7aaa2
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/composer/semver/zipball/198166618906cb2de69b95d7d47e5fa8aa1b2b95
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/dflydev/dflydev-dot-access-data/zipball/a23a2bf4f31d3518f3ecb38660c95715dfead60f
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/doctrine/inflector/zipball/6d6c96277ea252fc1304627204c3d5e6e15faa3b
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/doctrine/lexer/zipball/31ad66abc0fc9e1a1f2d9bc6a42668d2fbbcd6dd
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/dragonmantank/cron-expression/zipball/8c784d071debd117328803d86b2097615b457500
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/egulias/EmailValidator/zipball/d42c8731f0624ad6bdc8d3e5e9a4524f68801cfa
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/filp/whoops/zipball/d2102955e48b9fd9ab24280a7ad12ed552752c4d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/fruitcake/php-cors/zipball/3d158f36e7875e2f040f37bc0573956240a5a38b
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/guzzle/guzzle/zipball/b51ac707cfa420b7bfd4e4d5e510ba8008e822b4
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/guzzle/promises/zipball/481557b130ef3790cf82b713667b43030dc9c957
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/guzzle/psr7/zipball/21dc724a0583619cd1652f673303492272778051
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/guzzle/uri-template/zipball/4f4bbd4e7172148801e76e3decc1e559bdee34e1
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/hamcrest/hamcrest-php/zipball/f8b1c0173b22fa6ec77a81fe63e5b01eba7e6487
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/laravel/framework/zipball/5fd457f807570a962a53b403b1346efe4cc80bb8
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/laravel/pint/zipball/5016e263f95d97670d71b9a987bd8996ade6d8d9
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/mockery/mockery/zipball/1f4efdd7d3beafe9807b08156dfcb176d18f1699
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/nette/schema/zipball/da801d52f0354f70a638673c4a0f04e16529431d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/nette/utils/zipball/c930ca4e3cf4f17dcfb03037703679d2396d2ede
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/nunomaduro/termwind/zipball/dfa08f390e509967a15c22493dc0bac5733d9123
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/opentelemetry-php/api/zipball/610b79ad9d6d97e8368bcb6c4d42394fbb87b522
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/opentelemetry-php/context/zipball/d4c4470b541ce72000d18c339cfee633e4c8e0cf
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/opentelemetry-php/exporter-otlp/zipball/196f3a1dbce3b2c0f8110d164232c11ac00ddbb2
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/opentelemetry-php/gen-otlp-protobuf/zipball/673af5b06545b513466081884b47ef15a536edde
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/opentelemetry-php/sdk/zipball/8986bcbcbea79cb1ba9e91c1d621541ad63d6b3e
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/opentelemetry-php/sem-conv/zipball/8da7ec497c881e39afa6657d72586e27efbd29a1
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/orchestral/canvas-core/zipball/a8ebfa6c2e50f8c6597c489b4dfaf9af6789f62a
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/orchestral/sidekick/zipball/371ce2882ee3f5bf826b36e75d461e51c9cd76c2
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/orchestral/testbench/zipball/d0181240f93688448d4ae3b5479ec5ed70a87a47
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/orchestral/workbench/zipball/1da2ea95089ed3516bda6f8e9cd57c81290004bf
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/clock/zipball/e41a24703d4560fd0acb709162f73b8adfc3aa0d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/event-dispatcher/zipball/dbefd12671e8a14ec7f180cab83036ed26714bb0
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/http-client/zipball/bb5906edc1c324c9a05aa0873d40117941e5fa90
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/http-factory/zipball/2b4765fddfe3b508ac62f829e852b1501d3f6e8a
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/http-message/zipball/402d35bcb92c70c026d1a6a9883f06b2ead23d71
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/log/zipball/f16e1d5863e37f8d8c2a01719f5b34baa2b714d3
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-fig/simple-cache/zipball/764e0b3939f5ca87cb904f570ef9be2d78a07865
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/php-http/discovery/zipball/82fe4c73ef3363caed49ff8dd1539ba06044910d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/protocolbuffers/protobuf-php/zipball/c4ed1c1f9bbc1e91766e2cd6c0af749324fe87cb
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/ralouphie/getallheaders/zipball/120b605dfeb996808c31b6477290a714d356e822
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/ramsey/collection/zipball/344572933ad0181accbf4ba763e85a0306a8c5e2
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/ramsey/uuid/zipball/81f941f6f729b1e3ceea61d9d014f8b6c6800440
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/schmittjoh/php-option/zipball/638a154f8d4ee6a5cfa96d6a34dfbe0cffa9566d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/type/zipball/e549163b9760b8f71f191651d22acf32d56d6d4d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/sebastianbergmann/version/zipball/3e6ccf7657d4f0a59200564b08cead899313b53c
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/spatie/test-time/zipball/308242a6c7ce4af2455ee0ab61b7d3d627cb78fd
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/staabm/side-effects-detector/zipball/d8334211a140ce329c13726d4a715adbddd0a163
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/clock/zipball/b81435fbd6648ea425d1ee96a2d8e68f4ceacd24
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/css-selector/zipball/601a5ce9aaad7bf10797e3663faefce9e26c24e2
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/error-handler/zipball/99f81bc944ab8e5dae4f21b4ca9972698bbad0e4
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/event-dispatcher-contracts/zipball/59eb412e93815df44f05f342958efa9f46b1e586
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/event-dispatcher/zipball/b7dc69e71de420ac04bc9ab830cf3ffebba48191
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/finder/zipball/2a6614966ba1074fa93dae0bc804227422df4dfe
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/http-foundation/zipball/c061c7c18918b1b64268771aad04b40be41dd2e6
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/http-kernel/zipball/b796dffea7821f035047235e076b60ca2446e3cf
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/mailer/zipball/ab97ef2f7acf0216955f5845484235113047a31d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/mime/zipball/b1b828f69cbaf887fa835a091869e55df91d0e35
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-ctype/zipball/a3cc8b044a6ea513310cbd48ef7333b384945638
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-intl-grapheme/zipball/380872130d3a5dd3ace2f4010d95125fde5d5c70
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-intl-idn/zipball/9614ac4d8061dc257ecc64cba1b140873dce8ad3
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-intl-normalizer/zipball/3833d7255cc303546435cb650316bff708a1c75c
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-mbstring/zipball/6d857f4d76bd4b343eac26d6b539585d2bc56493
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-php80/zipball/0cc9dd0f17f61d8131e7df6b84bd344899fe2608
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-php82/zipball/5d2ed36f7734637dacc025f179698031951b1692
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-php83/zipball/17f6f9a6b1735c0f163024d959f700cfbc5155e5
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-uuid/zipball/21533be36c24be3f4b1669c4725c7d1d2bab4ae2
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/process/zipball/f24f8f316367b30810810d4eb30c543d7003ff3b
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/routing/zipball/8dc648e159e9bac02b703b9fbd937f19ba13d07c
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/string/zipball/f96476035142921000338bad71e5247fbc138872
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/translation-contracts/zipball/df210c7a2573f1913b2d17cc95f90f53a73d8f7d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/translation/zipball/ec25870502d0c7072d086e8ffba1420c85965174
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/uid/zipball/a69f69f3159b852651a6bf45a9fdd149520525bb
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/var-dumper/zipball/b8abe7daf2730d07dfd4b2ee1cecbf0dd2fbdabb
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/symfony/yaml/zipball/d4f4a66866fe2451f61296924767280ab5732d9d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/thephpleague/commonmark/zipball/10732241927d3971d28e7ea7b5712721fa2296ca
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/thephpleague/config/zipball/754b3604fb2984c71f4af4a9cbe7b57f346ec1f3
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/thephpleague/flysystem-local/zipball/6691915f77c7fb69adfb87dcd550052dc184ee10
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/thephpleague/flysystem/zipball/2203e3151755d874bb2943649dae1eb8533ac93e
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/thephpleague/mime-type-detection/zipball/2d6702ff215bf922936ccc1ad31007edc76451b9
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/thephpleague/uri-interfaces/zipball/08cfc6c4f3d811584fb09c37e2849e6a7f9b0742
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/thephpleague/uri/zipball/81fb5145d2644324614cc532b28efd0215bda430
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/tijsverkoyen/CssToInlineStyles/zipball/0d72ac1c00084279c1816675284073c5a337c20d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/vlucas/phpdotenv/zipball/24ac4c74f91ee2c193fa1aaa5c249cb0822809af
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/voku/portable-ascii/zipball/b1d923f88091c6bf09699efcd7c8a1b1bfd7351d
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/webmozarts/assert/zipball/11cb2199493b2f8a3b53e7f19068fc6aac760991
- Triggering command: /usr/bin/php8.3 -n -c /tmp/kQHCMO /usr/bin/composer install --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

if (! config('otel.enabled', true)) {
return;
}

对于启用的判断仅在 boot 做了检查，register 也没加，请你完善此问题

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…n when disabled Co-authored-by: overtrue <[email protected]>

Initial plan

72603df

Copilot AI assigned Copilot and overtrue Oct 11, 2025

Copilot started work on behalf of overtrue October 11, 2025 06:12 View session

Add enabled check to register() method to prevent service registratio…

4508610

…n when disabled Co-authored-by: overtrue <[email protected]>

Copilot AI changed the title ~~[WIP] Fix OpenTelemetry configuration check during register~~ Add enabled check to register() method to prevent service registration when disabled Oct 11, 2025

Copilot AI requested a review from overtrue October 11, 2025 06:24

Copilot finished work on behalf of overtrue October 11, 2025 06:24

overtrue marked this pull request as ready for review October 11, 2025 06:26

overtrue merged commit 6fd3159 into main Oct 11, 2025
5 checks passed

overtrue deleted the copilot/fix-otel-register-check branch October 11, 2025 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add enabled check to register() method to prevent service registration when disabled #7

Add enabled check to register() method to prevent service registration when disabled #7

Uh oh!

Copilot AI commented Oct 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Add enabled check to register() method to prevent service registration when disabled #7

Add enabled check to register() method to prevent service registration when disabled #7

Uh oh!

Conversation

Copilot AI commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Benefits

Testing

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 11, 2025 •

edited

Loading